New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize syntax tree size of Punctuated (without allocation for empty Punctuated) #1407

Closed

dtolnay wants to merge 2 commits into master from shrink

Owner

dtolnay commented Mar 17, 2023

Alternative attempt at #1406. Sadly this one has the same 20-30% improvement on syntax tree size and only 2-3% improvement on performance.

dtolnay added 2 commits

March 17, 2023 12:43


          Optimize syntax tree size of Punctuated

0844a62


          No allocation for empty Punctuated

Owner Author

dtolnay commented Mar 17, 2023

I guess it's good news that performance appears not to be sensitive to syntax tree size, even for quite large nodes (200–300 bytes).

dtolnay closed this

dtolnay deleted the shrink branch

March 17, 2023 20:35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment