Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict PartialOrd comparison to only tokens in the same buffer #1237

Merged
merged 2 commits into from Oct 20, 2022
Merged

Restrict PartialOrd comparison to only tokens in the same buffer #1237

merged 2 commits into from Oct 20, 2022

Commits on Oct 20, 2022

  1. Restrict PartialOrd comparison to only tokens in the same buffer

    @dtolnay
    dtolnay committed Oct 20, 2022
    Copy the full SHA
    f6f7d8a View commit details
    Browse the repository at this point in the history

  2. Ignore cast_possible_wrap pedantic clippy lint 

        error: casting `usize` to `isize` may wrap around the value
      --> src/buffer.rs:56:46
       |
    56 |                     entries.push(Entry::End(-(group_end_index as isize)));
       |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^
       |
       = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_possible_wrap
       = note: `-D clippy::cast-possible-wrap` implied by `-D clippy::pedantic`

    error: casting `usize` to `isize` may wrap around the value
      --> src/buffer.rs:82:34
       |
    82 |         entries.push(Entry::End(-(entries.len() as isize)));
       |                                  ^^^^^^^^^^^^^^^^^^^^^^^^
       |
       = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_possible_wrap
    @dtolnay
    dtolnay committed Oct 20, 2022
    Copy the full SHA
    8db5adb View commit details
    Browse the repository at this point in the history