Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement PartialOrd for Cursor #1236

Merged
merged 3 commits into from Oct 20, 2022
Merged

Implement PartialOrd for Cursor #1236

merged 3 commits into from Oct 20, 2022

Commits on Oct 20, 2022

  1. Add test for Item::Verbatim splitting a None group 

    (see issue dtolnay#1235)
    @CAD97
    CAD97 committed Oct 20, 2022
    Copy the full SHA
    26a605e View commit details
    Browse the repository at this point in the history

  2. Implement PartialOrd for Cursor

    @CAD97
    CAD97 committed Oct 20, 2022
    Copy the full SHA
    e9fb6a9 View commit details
    Browse the repository at this point in the history

  3. Handle the case where verbatim enters a None group 

    Fixes dtolnay#1235. As seen in that issue, a syntax node can actually cross the
border of a None-delimited group, due to such groups being transparent
to the parser in most cases. In the cases that this can occur, the
presence of the group is known to be semantically irrelevant, so we just
explicitly ignore the presence of the group.

It's important that we only ignore None-delimited groups when the
verbatim end requires entering the group, as such groups can have semantic
impact (such as grouping binary operator chains) in other positions.
    @CAD97
    CAD97 committed Oct 20, 2022
    Copy the full SHA
    f6a43aa View commit details
    Browse the repository at this point in the history