Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid Box invalidation to be compatible with tag-raw-pointers #1166

Merged
merged 1 commit into from Apr 29, 2022
Merged

Avoid Box invalidation to be compatible with tag-raw-pointers #1166

merged 1 commit into from Apr 29, 2022

Commits on Apr 29, 2022

  1. Avoid Box invalidation, for tag-raw-pointers 

    It looks like the only outstanding issue aliasing issue in this repo
(with raw pointer tagging) was this one move of a Box after saving a
pointer to the allocation that the Box guards. This is UB according to
the Stacked Borrows with raw pointer tagging in combination with the way
rustc applies noalias to Box. As is often the case, the resolution here
is to convert the Box down to a raw pointer before a pointer into the
allocation is created.
    @saethlin
    saethlin committed Apr 29, 2022
    Copy the full SHA
    95f242c View commit details
    Browse the repository at this point in the history