Merge pull request #1148 from dtolnay/fnmutself

Fix panic on comma after `mut self` in bare fn type
dtolnay · Mar 16, 2022 · 6daa474 · 6daa474
2 parents 9a66997 + 4a3a83d
commit 6daa474
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/ty.rs b/src/ty.rs
@@ -740,7 +740,10 @@ pub mod parsing {
                         break;
                     }
 
-                    inputs.push_punct(args.parse()?);
+                    let comma = args.parse()?;
+                    if !has_mut_self {
+                        inputs.push_punct(comma);
+                    }
                 }
 
                 inputs

diff --git a/tests/test_ty.rs b/tests/test_ty.rs
@@ -9,6 +9,7 @@ use syn::Type;
 #[test]
 fn test_mut_self() {
     syn::parse_str::<Type>("fn(mut self)").unwrap();
+    syn::parse_str::<Type>("fn(mut self,)").unwrap();
     syn::parse_str::<Type>("fn(mut self: ())").unwrap();
     syn::parse_str::<Type>("fn(mut self: ...)").unwrap_err();
     syn::parse_str::<Type>("fn(mut self: mut self)").unwrap_err();