This repository has been archived by the owner on Mar 25, 2024. It is now read-only.
Deserialize empty plain scalar to an empty map or seq #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
molpopgen
added a commit
to molpopgen/demes-rs
that referenced
this pull request
Aug 22, 2022
serde_yaml 0.9.7 resulted in a regression, accepting `metadata:` (empty metadata mappings) instead of returning Err. See dtolnay/serde-yaml#304 and dtolnay/serde-yaml#312 This change uses a custom deserializer to error in this case.
molpopgen
added a commit
to molpopgen/demes-rs
that referenced
this pull request
Aug 22, 2022
serde_yaml 0.9.7 resulted in a regression, accepting `metadata:` (empty metadata mappings) instead of returning Err. See dtolnay/serde-yaml#304 and dtolnay/serde-yaml#312 This change uses a custom deserializer to error in this case.
molpopgen
added a commit
to molpopgen/demes-rs
that referenced
this pull request
Aug 22, 2022
serde_yaml 0.9.7 resulted in a regression, accepting `metadata:` (empty metadata mappings) instead of returning Err. See dtolnay/serde-yaml#304 and dtolnay/serde-yaml#312 This change uses a custom deserializer to error in this case.
molpopgen
added a commit
to molpopgen/demes-rs
that referenced
this pull request
Aug 22, 2022
* refactor: Metadata now uses custom deserializer serde_yaml 0.9.7 resulted in a regression, accepting `metadata:` (empty metadata mappings) instead of returning Err. See dtolnay/serde-yaml#304 and dtolnay/serde-yaml#312 This change uses a custom deserializer to error in this case. * fix: fix clippy::unnecessary_to_owned lint
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #304.