Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate ptr->int->ptr casting from Identifier implementation #273

Merged
merged 4 commits into from May 2, 2022

Conversation

dtolnay
Copy link
Owner

@dtolnay dtolnay commented May 1, 2022

This lets us pass Miri's raw pointer tagging.

@saethlin
Copy link

saethlin commented May 1, 2022

This is much sleeker. I like it.

By eye it looks like this could accommodate a target where pointers are 16 bytes. I don't think the flexibility gets in the way, but is there a way to test that this works on such a target?

@dtolnay dtolnay merged commit 123772e into master May 2, 2022
@dtolnay dtolnay deleted the provenance branch May 2, 2022 01:44
@dtolnay
Copy link
Owner Author

dtolnay commented May 2, 2022

Yeah this doesn't particularly care how big a pointer is. 16 bit, 32 bit, 64 bit, 128 bit should all work.

It's possible Miri could add some made-up target specifications for testing such scenarios. Changes to libcore might also be required though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants