Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.0.8 breaks Send/Sync impls on some public structs #274

Closed
cr0sh opened this issue May 2, 2022 · 1 comment · Fixed by #275
Closed

v1.0.8 breaks Send/Sync impls on some public structs #274

cr0sh opened this issue May 2, 2022 · 1 comment · Fixed by #275

Comments

@cr0sh
Copy link

cr0sh commented May 2, 2022

Hi, the recent release on semver has breaking changes regarding Send/Sync impl on Prerelease and Comparator. It seems like that the root cause of the breakage is the NonNull<u8> field in Identifier introduced by #273. Would unsafe impl Send/Sync for Identfier {} be sufficient to resolve it?
@dtolnay dtolnay mentioned this issue May 2, 2022
Merged
@detly detly mentioned this issue May 2, 2022
Closed
@dtolnay
Copy link
Owner

dtolnay commented May 2, 2022

Fixed in 1.0.9. Sorry about the breakage!

@mulkieran mulkieran mentioned this issue May 5, 2022
Closed
@gakonst gakonst mentioned this issue May 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Impl Send + Sync for Identifier dtolnay/semver
2 participants
@dtolnay @cr0sh