Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorder arguments in quote_token and quote_token_spanned #210

Merged
merged 3 commits into from Mar 17, 2022
Merged

Reorder arguments in quote_token and quote_token_spanned #210

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
738b651
reorder `quote_token` arguments
lqd Mar 17, 2022
8ee39a8
reorder `quote_token_spanned` arguments
lqd Mar 17, 2022
9af37e4
Add comment to quote_token about the tokens order
lqd Mar 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/lib.rs
View file
Open in desktop
Expand Up @@ -842,9 +842,9 @@ macro_rules! quote_token_with_context_spanned {
}

// These rules are ordered by approximate token frequency, at least for the
// first 10 or so, to improve compile times. Having `ident` first is by far the
// most important, because it's typically 2-3x more common than the next most
// common token.
lqd marked this conversation as resolved.
Show resolved Hide resolved
// first 10 or so, to improve compile times. Similarly, having the `$tokens` at
// the end allows for failing rules to fail as quickly as possible, and also helps
// reduce compile times for crates that use `quote!` heavily.
#[macro_export]
#[doc(hidden)]
macro_rules! quote_token {
Expand Down