Re-add updated Span::start()/end()/line()/column() span-locations methods #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MingweiSamuel
force-pushed
the
new-span-locs
branch
from
d7f8ce8
to
b87f0b6
Compare
MingweiSamuel
force-pushed
the
new-span-locs
branch
2 times, most recently
from
b769b45
to
886c0d8
Compare
MingweiSamuel
force-pushed
the
new-span-locs
branch
from
886c0d8
to
7dbae7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated for rust-lang/rust#111571
My impression is that this can't be merged as it is a breaking change? But providing the changeset anyway
perhaps it could be compatible using the old Span::before and Span::after names, but that is silly