Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: required info to build via Bazel in external repo #963

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jon-chuang
Copy link

@jon-chuang jon-chuang commented Nov 27, 2021

rustc requires linker

Alternatively, these flags should be passed into the rust_binary rule

Copy link
Owner

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I don't immediately understand why this would be necessary. For example, rules_rust's examples/crate_universe/using_cxx uses cxx without lld, and seems to work.

@bsilver8192
Copy link
Contributor

I suspect it depends on your toolchain and which cxx features you use. Some toolchains will use a linker that doesn't care about the order by default, and some very minimal uses of cxx don't have the circular linking order either. #1069 adds more explicit documentation about the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants