Switch to bundled buck2 prelude #1345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JakobDegen, this is working on Linux and macOS, but not Windows. BUILD FAILED
From load at implicit location
Caused by:
0: non-forward relative bundled path (internal error)
1: expected a normalized path but got an un-normalized path instead: `abi\BUCK.v2` |
facebook-github-bot
pushed a commit
to facebook/buck2
that referenced
this pull request
May 9, 2024
Summary: dtolnay/cxx#1345 (comment) This is kind of a bad test. The reason that this was able to slip through in the first place is because most of this stuff is tested in integration tests, which aren't run on cargo builds of buck2. But writing a better test is not super trivial, and I'd rather spend time deprecating cargo builds Reviewed By: samkevich Differential Revision: D57148214 fbshipit-source-id: 38e5148a2c0b2436dab6ab2a70cd5dbc5b01d185
|
Fixed by facebook/buck2@9de4fc1. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://buck2.build/docs/users/advanced/external_cells/