Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom deleter support to UniquePtr #1305

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Commits on Jan 10, 2024

  1. Add custom deleter support to UniquePtr

    Add the possibility to use shared trivial types as deleters for objects managed
    by std::unique_ptr / UniquePtr.
    darkwisebear committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    2b822f8 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2024

  1. Fix failing tests on Linux

    GCC does not accept an extern "C" storage class specifier along with
    definition of the global variable. Split declaration and definition to
    overcome this.
    darkwisebear committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    8336f62 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2024

  1. Support unique_ptr deleter as 2nd member

    Apparently MacOS's unique_ptr implementation puts the
    deleter as the 2nd member. Reflect this in the unique_ptr definition.
    darkwisebear committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    424dcba View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2024

  1. Configuration menu
    Copy the full SHA
    2b73827 View commit details
    Browse the repository at this point in the history
  2. Fix UI tests

    * Add unnamed lifetimes to drop implementation for UniquePtrTarget
    * Update expected stderr to include the deleter type parameter.
    darkwisebear committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    a6b3bed View commit details
    Browse the repository at this point in the history