Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use http_archive for buck crates without vendoring #1207

Merged
merged 1 commit into from Apr 21, 2023
Merged

Conversation

dtolnay
Copy link
Owner

@dtolnay dtolnay commented Apr 19, 2023

This eliminates the cargo vendor and reindeer step. Users can checkout the repo and immediately run buck2 build.

$ git clone https://github.com/dtolnay/cxx
$ cd cxx
$ git submodule update --init
$ cargo vendor --versioned-dirs --locked --manifest-path third-party/Cargo.toml third-party/vendor
$ reindeer --third-party-dir third-party buckify
$ buck2 build ...

@dtolnay dtolnay force-pushed the httparchive branch 4 times, most recently from d01c6d3 to cc6759a Compare April 21, 2023 15:16
@dtolnay dtolnay marked this pull request as ready for review April 21, 2023 15:26
@dtolnay dtolnay merged commit efb66d5 into master Apr 21, 2023
20 checks passed
@dtolnay dtolnay deleted the httparchive branch April 21, 2023 15:27
@dtolnay
Copy link
Owner Author

dtolnay commented Apr 21, 2023

@steveklabnik — I had to make some changes to the prelude's implementation of http_archive and rust_library, so if you are interested in this you'll need an updated prelude along with new reindeer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant