Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CXX_RS_EXPORT, CXX_CPP_EXPORT macros to cxx.cc #1025

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add CXX_RS_EXPORT, CXX_CPP_EXPORT macros to cxx.cc #1025

wants to merge 3 commits into from

Commits on Mar 16, 2022

  1. Add CXX_RS_EXPORT, CXX_CPP_EXPORT macros to cxx.cc. 

    In some non-Cargo build configurations, the Rust and C++ side of cxx
bindings may end up in different binaries. In some environments,
this requires symbols to be explicitly exported using
__declspec(dllexport) or similar directives. A previous change added
the --cxx-impl-annotations switch on the cxx-gen command line tool,
providing the opportunity to specify such directives for dynamically
generated parts of the cxx bindings.

It turns out to be similarly useful to export symbols from cxx.cc.
This change adds a pair of preprocessor symbols which folks can define
if they wish to export these symbols too.
    @adetaylor
    adetaylor committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    821b204 View commit details
    Browse the repository at this point in the history

  2. clang-format 

    No functional changes.
    @adetaylor
    adetaylor committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    38d91cf View commit details
    Browse the repository at this point in the history

  3. Update cmd test.

    @adetaylor
    adetaylor committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    08be363 View commit details
    Browse the repository at this point in the history