Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow fully elaborated ::core::marker::Trait supertraits #170

Merged
merged 1 commit into from Jul 29, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.toml
Expand Up @@ -16,7 +16,7 @@ proc-macro = true
[dependencies]
proc-macro2 = "1.0"
quote = "1.0"
syn = { version = "1.0.61", features = ["full", "visit-mut"] }
syn = { version = "1.0.61", features = ["full", "visit-mut", "extra-traits"] }

[dev-dependencies]
futures = "0.3"
Expand Down
2 changes: 1 addition & 1 deletion src/expand.rs
Expand Up @@ -396,7 +396,7 @@ fn positional_arg(i: usize, pat: &Pat) -> Ident {
fn has_bound(supertraits: &Supertraits, marker: &Ident) -> bool {
for bound in supertraits {
if let TypeParamBound::Trait(bound) = bound {
if bound.path.is_ident(marker) {
if bound.path.is_ident(marker) || bound.path == parse_quote!(::core::marker::#marker) {
return true;
}
}
Expand Down
13 changes: 13 additions & 0 deletions tests/test.rs
Expand Up @@ -1363,3 +1363,16 @@ pub mod issue161 {
}
}
}

// https://github.com/dtolnay/async-trait/issues/169
#[deny(where_clauses_object_safety)]
pub mod issue169 {
use async_trait::async_trait;

#[async_trait]
pub trait Trait: ::core::marker::Sync {
async fn f(&self) {}
}

pub fn test(_t: &dyn Trait) {}
}