Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant Backtrace provide_ref from ContextError #281

Merged
merged 2 commits into from
Oct 21, 2022
Merged

Remove redundant Backtrace provide_ref from ContextError #281

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d2b6a3
Remove redundant Backtrace provide_ref from ContextError
dtolnay Oct 20, 2022
0b42fed
Call Provider::provide not Error::provide
dtolnay Oct 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/context.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use core::convert::Infallible;
use core::fmt::{self, Debug, Display, Write};

#[cfg(backtrace)]
use std::any::Demand;
use std::any::{Demand, Provider};

mod ext {
use super::*;
Expand Down Expand Up @@ -159,8 +159,7 @@ where

#[cfg(backtrace)]
fn provide<'a>(&'a self, demand: &mut Demand<'a>) {
demand.provide_ref(self.error.backtrace());
self.error.provide(demand);
Provider::provide(&self.error, demand);
}
}

Expand Down