bytewords: use static allocated hash map #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #153 +/- ##
==========================================
- Coverage 92.32% 92.29% -0.04%
==========================================
Files 6 5 -1
Lines 717 714 -3
==========================================
- Hits 662 659 -3
Misses 55 55
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jeandudey
force-pushed
the
jeandudey/use-static-allocated-hashmap
branch
from
8feb133
to
a1c954c
Compare
|
Hey @jeandudey , thanks for the PR! I would very much welcome Interestingly, Could you please rebase the PR? Then I'll merge it. |
The hash map is generated at compile time, this is to not allocate at runtime the HashMap as I'm going to make some PRs to make this crate no_std friendly. Signed-off-by: Jean-Pierre De Jesus DIAZ <me@jeandudey.tech>
jeandudey
force-pushed
the
jeandudey/use-static-allocated-hashmap
branch
from
a1c954c
to
e8cd00e
Compare
Thanks! I've rebased the PR |
dspicher
approved these changes
Dec 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hash map is generated at compile time, this is to not allocate at runtime the
HashMapas I'm going to make some PRs to make this crateno_stdfriendly :D.It's another dependency but reduces one.