Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement codemirror addons #287

Merged
merged 7 commits into from
Oct 13, 2020
Merged

Implement codemirror addons #287

merged 7 commits into from
Oct 13, 2020

Conversation

stoppert
Copy link
Contributor

@stoppert stoppert commented Oct 11, 2020 •
edited by dshoreman

This adds the following codemirror addons from #190:

  • simplescrollbars
  • active-line
  • continuecomment
  • matchbrackets
  • closebrackets
  • trailingspace (I ignored the idea with the ::before tag content because it only adds a single span for all trailing spaces and not a span per space)
  • closetag

@codecov
Copy link

codecov bot commented Oct 11, 2020 •
edited

Codecov Report

Merging #287 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #287   +/-   ##
==========================================
  Coverage      94.26%   94.26%           
  Complexity       336      336           
==========================================
  Files             47       47           
  Lines            855      855           
==========================================
  Hits             806      806           
  Misses            49       49

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f24e10...1f6d382. Read the comment docs.

@stoppert stoppert mentioned this pull request Oct 11, 2020
Open
9 tasks
@stoppert stoppert changed the title Feat codemirror addons Implement codemirror addons Oct 11, 2020
@dshoreman
Copy link
Owner

Thank you for this, saved me a ton of time even if it's just adding a couple imports :D

I've rebased on develop so I could test it with the changes from #276 and 'tis all looking good. Dropped the 'order options' commit though - this way they're vaguely grouped by what they do so it's easier to see related options at a glance.

Will update #190's description so I can check off the bits added here, then I'll get this merged <3

@dshoreman dshoreman self-assigned this Oct 13, 2020
@dshoreman dshoreman added this to In progress in File Manager via automation Oct 13, 2020
@dshoreman dshoreman linked an issue Oct 13, 2020 that may be closed by this pull request
Improve scroll bars in the file editor #190
Open
9 tasks
@dshoreman dshoreman merged commit 0d50790 into dshoreman:develop Oct 13, 2020
File Manager automation moved this from In progress to Done Oct 13, 2020
@stoppert stoppert deleted the feat-codemirror-addons branch October 8, 2021 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dshoreman dshoreman

Labels
enhancement New feature or request hacktoberfest-accepted
Projects
File Manager
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve scroll bars in the file editor
2 participants
@stoppert @dshoreman