Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve scroll bars in the file editor #190

Open
6 of 9 tasks
dshoreman opened this issue Nov 6, 2019 · 2 comments · Fixed by #287
Open
6 of 9 tasks

Improve scroll bars in the file editor #190

dshoreman opened this issue Nov 6, 2019 · 2 comments · Fixed by #287
Labels
enhancement New feature or request

Comments

@dshoreman
Copy link
Owner

dshoreman commented Nov 6, 2019

There's nothing wrong with the default browser scrollbars, but they're not the most attractive either.

Using the Simple Scrollbar addon for CodeMirror, we should set the scrollbarStyle option to 'overlay' to get some better looking bars. This can be further tweaked by setting some custom CSS that's more inline with both the light and dark themes.

Other Addons Worth Implementing

@dshoreman dshoreman added the enhancement New feature or request label Nov 6, 2019
@dshoreman dshoreman added this to To do in File Manager via automation Nov 6, 2019
@stoppert
Copy link
Contributor

I created #287 for this

  • search/jumptoline wouldnt work for me (Alt+G opens the Firefox Search for me?)
  • fold/foldgutter didnt show any gutters but not any error either

@dshoreman dshoreman linked a pull request Oct 13, 2020 that will close this issue
File Manager automation moved this from To do to Done Oct 13, 2020
@dshoreman
Copy link
Owner Author

I created #287 for this

Merged, thanks!

* search/jumptoline wouldnt work for me (Alt+G opens the Firefox Search for me?)

I get LastPass' "Generate password" page opening when I press Alt+G, and the find bar pops up with Ctrl+G which seems to be bound to "Find next"...

What're the common bindings used in most editors? I've got Ctrl+G setup in vim similar to ctrlp in sublime, (but searching content not filenames). "Jump to line 13" in vim is literally 13G, but that's probably difficult in CodeMirror without the vi mode stuff and isn't really intuitive to non-vim users either.

* fold/foldgutter didnt show any gutters but not any error either

I saw something about the gutters while I was reading through some bits earlier, so that could explain them not showing up. Iirc it adds classes to the gutters but doesn't style them by default, which seems a bit odd but there ya go! I'll have a play later and see if I can find anything

@dshoreman dshoreman reopened this Oct 13, 2020
File Manager automation moved this from Done to In progress Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
File Manager
  
In progress
Development

Successfully merging a pull request may close this issue.

2 participants