Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test(assertions): Simplify assertResultErrors to avoid closure serial…
…ization (#1159) This commit changes some loops into built-in PHP functions to simplify the code and eliminate the need for closures. Additionally this switches over to an `assertEmpty` from `assertEquals`. This achieves the same test result and in the message still provides the errors. However it prevents test failures with weird serialization complaints that are caused by closures in function arguments of GraphQL Error stacktraces. See sebastianbergmann/phpunit#4371 (comment) The downside to this change is that we may lose some contextual information that the full error in the array comparison may provide. The upside is that we can actually see why tests fail since in a lot of cases this beneficial diff doesn't make it into the test output anyway. So all-in-all this is a step forward.
- Loading branch information