Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.1.0 deprecations #4338

Merged
merged 3 commits into from Oct 25, 2021
Merged

2.1.0 deprecations #4338

merged 3 commits into from Oct 25, 2021

Conversation

zUniQueX
Copy link
Member

@zUniQueX zUniQueX commented Oct 8, 2021

Since most dependencies have released 'jakarta versions' (only logback hasn't at the moment), Dropwizard 3.0.0 could be built soon. But therefore some properties have to be removed:

  1. Upgrade to Jetty 11: excluding user agents for GZIP is not supported any more. Therefore remove it.
  2. Upgrade to Httpclient 5 (possible, as only the class LocalizationMessages from jersey-apache-connector seems to be used):
    • The RequestConfig.Builder doesn't support normalizeURI any more
    • ServiceUnavailableRetryStrategy and HttpRequestRetryHandler are combined in HttpRequestRetryStrategy. Therefore deprecate using ServiceUnavailableRetryStrategy
    • HttpProcessor cannot be provided any more
  3. The DefaultHealthFactory defines two getter and setter methods for the property healthChecks. Therefore deprecate one

The dependency updates will probably introduce more changes, but this is what I recognized so far.

@zUniQueX zUniQueX requested a review from a team as a code owner October 8, 2021 17:29
@jplock jplock added this to the 2.1.0 milestone Oct 25, 2021
@jplock jplock merged commit 2acf064 into dropwizard:master Oct 25, 2021
@javajosh
Copy link

javajosh commented Nov 9, 2021

Hey there. I came here looking for some idea when jetty would be upgraded past 9 - I for one am looking forward to the upgrade!

@joschi
Copy link
Member

joschi commented Nov 9, 2021

@javajosh Jetty 10 (javax.servlet namespace) requires Java 11 or higher as well as Jetty 11 (jakarta.servlet namespace).

Dropwizard 2.x is targeting Java 8 or higher, so Dropwizard 2.x most likely won't upgrade to Jetty 10 or later.

@zUniQueX
Copy link
Member Author

zUniQueX commented Nov 9, 2021

Additionally, the upgrade seems to be impossible at the moment. There are conflicts with logback-access. See jetty/jetty.project#5996 (comment) for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants