Remove unused loop (3) #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielrh
requested changes
May 4, 2024
src/enc/backward_references/hq.rs
Outdated
| missing_symbol_sum = missing_symbol_sum.wrapping_add(1); | ||
| for i in 0..histogram_size { | ||
| if histogram[i] == 0 { | ||
| sum = sum.wrapping_add(1); |
There was a problem hiding this comment.
can you keep the variable named "missing_symbol_sum"...it's confusing to a reader why we might compute the log2sum of a "partial" sum... if it's called as a different variable then the logic makes sense.
if you want to make it clearer you could reduce the scope of "sum" above to a nested block and then have missing_symbol_sum be defined outside the block (and assigned in it)
The nested loop is only executed once, so made the code much more readable and clearer by removing it. Also, cleaned up the rest of the SetCost function
danielrh
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nested loop is only executed once, so made the code much more readable and clearer by removing it.
Also, cleaned up the rest of the SetCost function