Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert to GitHub Actions, fix Python 3.5.1 and add newer Pythons #108

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

terencehonles
Copy link

I noticed getting tests through Travis is taking a long time now. I had also fixed Python 3.5.1 in #107 but it looks like there were more adjustments to the requirements.txt to not rely on Travis's built in / pre-installed tools.

GitHub Actions does not support Python 3.5.1, but I put a request for it actions/setup-python#187.

@cclauss
Copy link

cclauss commented Apr 10, 2021

@terencehonles Please see the comment about Python 3.5.1 in #110

@JukkaL Would it be possible to review and land this PR (or similar) to test on current versions of Python?

@terencehonles
Copy link
Author

terencehonles commented Apr 10, 2021

@cclauss ack.

I dropped Python 3.5.1, @gvanrossum are you suggesting to drop 3.5 too? x-ref: #110 (comment)

@terencehonles terencehonles force-pushed the update-ci branch 2 times, most recently from 48ee7b3 to 9b214f5 Compare April 10, 2021 20:09
@terencehonles
Copy link
Author

It looks like GitHub Actions would also need to be enabled in this repo/org. You can see the runs in my fork: https://github.com/terencehonles/pyannotate/actions

@terencehonles
Copy link
Author

It looks like typed-ast is broken on Python 3.10 and broke since I opened this PR. I changed Python 3.10 to be an optional check for now: https://github.com/terencehonles/pyannotate/runs/2314171569?check_suite_focus=true#step:5:55

@terencehonles
Copy link
Author

Looks like that was already fixed but not yet released: python/typed_ast#158

@CLAassistant
Copy link

CLAassistant commented Apr 16, 2022

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants