Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc generation and PyPI uploads by pinning to Python 3.7 #500

Merged
merged 4 commits into from
May 14, 2024

Conversation

maxbelanger
Copy link
Contributor

@maxbelanger maxbelanger commented May 13, 2024

  • Per the docs, ReadTheDocs now requires a version 2 config file. In it, we pin the version used to generate the docs to Python 3.7, which matches what is currently tested (and green) in CI.
  • PyPI uploads were still configured to run on the latest version of Python (currently 3.12). We pin this back to Python 3.7, which make it less likely to break in mysterious ways.

build:
os: ubuntu-20.04
tools:
python: "3.7"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This now matches what we actually run to test that we can generate docs in the CI workflow.

Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.26%. Comparing base (3173f6e) to head (0113034).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #500   +/-   ##
=======================================
  Coverage   64.26%   64.26%           
=======================================
  Files          31       31           
  Lines       53579    53579           
  Branches     3905     3905           
=======================================
  Hits        34430    34430           
  Misses      18989    18989           
  Partials      160      160           
Flag Coverage Δ
integration 64.17% <ø> (ø)
unit 63.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxbelanger maxbelanger marked this pull request as ready for review May 13, 2024 23:49
@maxbelanger maxbelanger changed the title Fix doc generation and PyPi uploads by pinning to Python 3.7 Fix doc generation and PyPI uploads by pinning to Python 3.7 May 14, 2024
@maxbelanger maxbelanger merged commit 52893f0 into main May 14, 2024
24 checks passed
@maxbelanger maxbelanger deleted the dbx-max-fix-docs branch May 14, 2024 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants