Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore CI, including Python 2.7 #492

Merged
merged 10 commits into from
May 8, 2024
Merged

Restore CI, including Python 2.7 #492

merged 10 commits into from
May 8, 2024

Conversation

maxbelanger
Copy link
Contributor

@maxbelanger maxbelanger commented May 7, 2024

  • Restores CI to a green state to aid in landing other changes.
  • Python 2.7 is still covered, but only on Ubuntu and excluding PyPy. Changes are made to requirements.txt et al to ensure this works.
  • Fixes an integration test breaking due to backend changes, to be investigated separately.

@maxbelanger maxbelanger changed the title WIP: Restore CI, including Python 2.7 Restore CI, including Python 2.7 May 7, 2024
@maxbelanger maxbelanger marked this pull request as ready for review May 7, 2024 20:47
@april
Copy link

april commented May 7, 2024

Looks good to me, with the caveat that I am relying on the CI/CD pipeline to test this for me.

maxbelanger added a commit that referenced this pull request May 8, 2024
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.26%. Comparing base (487793d) to head (8cca9df).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #492      +/-   ##
==========================================
+ Coverage   63.69%   64.26%   +0.56%     
==========================================
  Files          31       31              
  Lines       52609    52609              
  Branches     3841     3841              
==========================================
+ Hits        33510    33807     +297     
+ Misses      19064    18641     -423     
- Partials       35      161     +126     
Flag Coverage Δ
integration 64.17% <ø> (?)
unit 63.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxbelanger maxbelanger merged commit 75596da into main May 8, 2024
27 of 28 checks passed
@maxbelanger maxbelanger deleted the dbx-max-fix-ci branch May 8, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants