Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend test matrix up to 3.12 #484

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Extend test matrix up to 3.12 #484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5cc7915
Extend test matrix up to 3.12 and format python versions as strings
foarsitter Oct 31, 2023
3c5c342
Add setuptools to setup_requires and as hard dependency
foarsitter Nov 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
39 changes: 31 additions & 8 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,25 @@ jobs:
strategy:
matrix:
os: [macos-latest, windows-latest]
python-version: [2.7, 3.5, 3.6, 3.7, 3.8, pypy-2.7, pypy-3.7]
python-version: [
"2.7",
"3.5",
"3.6",
"3.7",
"3.8",
"3.9",
"3.10",
"3.11",
"3.12",
"pypy-2.7",
"pypy-3.7"
]
exclude:
- os: windows-latest
python-version: 3.6
python-version: "3.6"
include:
- os: ubuntu-latest
python-version: 3.7
python-version: "3.7"
steps:
- uses: actions/checkout@v2
- name: Setup Python environment
Expand Down Expand Up @@ -65,13 +77,25 @@ jobs:
strategy:
matrix:
os: [macos-latest, windows-latest]
python-version: [2.7, 3.5, 3.6, 3.7, 3.8, pypy-2.7, pypy-3.7]
python-version: [
"2.7",
"3.5",
"3.6",
"3.7",
"3.8",
"3.9",
"3.10",
"3.11",
"3.12",
"pypy-2.7",
"pypy-3.7"
]
exclude:
- os: windows-latest
python-version: 3.6
python-version: "3.6"
include:
- os: ubuntu-latest
python-version: 3.7
python-version: "3.7"
steps:
- uses: actions/checkout@v2.3.4
- name: Setup Python environment
Expand All @@ -82,8 +106,7 @@ jobs:
run: |
python -m pip install --upgrade pip
pip install flake8 pytest
pip install -r requirements.txt
pip install -r test/requirements.txt
pip install -r requirements.txt
python setup.py install
- name: Run Integration Tests
env:
Expand Down
1 change: 1 addition & 0 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,4 @@ pytest-runner
sphinx
twine
wheel
setuptools
5 changes: 5 additions & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
# Pin pytest-runner to 5.2.0, since 5.3.0 uses `find_namespaces` directive, not supported in
# Python 2.7
'pytest-runner == 5.2.0',
'setuptools'
]

# WARNING: This imposes limitations on test/requirements.txt such that the
Expand Down Expand Up @@ -77,6 +78,10 @@
'Programming Language :: Python :: 3.6',
'Programming Language :: Python :: 3.7',
'Programming Language :: Python :: 3.8',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dropbox-sdk-python/setup.py

Line 36 in f40e73f

'pytest-runner == 5.2.0',

I think something like 'setuptools; python_version>="3.12"' should be added to the setup_requires list.
Without this I can't create a virtual env for this library on Python 3.12

See: https://docs.python.org/3/whatsnew/3.12.html

  • gh-95299: Do not pre-install setuptools in virtual environments created with venv. This means that distutils, setuptools, pkg_resources, and easy_install will no longer available by default; to access these run pip install setuptools in the activated virtual environment.

'Programming Language :: Python :: 3.9',
'Programming Language :: Python :: 3.10',
'Programming Language :: Python :: 3.11',
'Programming Language :: Python :: 3.12',
'Programming Language :: Python :: Implementation :: CPython',
'Programming Language :: Python :: Implementation :: PyPy',
'Topic :: Software Development :: Libraries :: Python Modules',
Expand Down
2 changes: 1 addition & 1 deletion tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tox]

envlist = py{27,34,35,36,37,38,39-dev,py,py3},check,lint,docs,test_unit,coverage
envlist = py{27,34,35,36,37,38,39,310,311,312,py,py3},check,lint,docs,test_unit,coverage
skip_missing_interpreters = true

[flake8]
Expand Down