Binary Compatibility in our Final JAR #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 23, 2022
handstandsam
force-pushed
the
binary-compat-java-jar
branch
2 times, most recently
from
dc73017
to
4436039
Compare
handstandsam
force-pushed
the
binary-compat-java-jar
branch
from
4436039
to
86f5190
Compare
Baseline (before any Kotlin code added, or refactored out of the monolith) Binary compatibility maintained except for: 1. The following classes are now final and cannot be extended. com.dropbox.core.android.Auth com.dropbox.core.android.DbxOfficialAppConnector 2. In com.dropbox.core.android.AuthActivity, constants for the Intent Extra Keys were moved to com.dropbox.core.android.internal.DropboxAuthIntent Added binary compatibility check to Github Action. Update build.gradle This was added for #254 Added binary compatibility check in GitHub Action. Dependency Guard Baseline Binary Compatibility Validator Changes since v5.3.0
handstandsam
force-pushed
the
binary-compat-java-jar
branch
from
86f5190
to
b40e950
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took a baseline before the stone spec update and the kotlin refactor, and then updated with the resulting code.
Binary Compatibility Changes since
v5.3.0(see changes):finaland cannot be extended.com.dropbox.core.android.Authcom.dropbox.core.android.DbxOfficialAppConnectorcom.dropbox.core.android.AuthActivity, constants for the Intent Extra Keys were moved tocom.dropbox.core.android.internal.DropboxAuthIntentRelated to #441 where we focused on maintaining the compatibility just in the Kotlin Portion as it was developed.
Fixes #445