Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds generated source to repo and adds CI checks #418

Merged
merged 5 commits into from
Aug 29, 2022
Merged

Conversation

wdziemia
Copy link
Contributor

@wdziemia wdziemia commented Aug 29, 2022

It was impossible to tell what the changes to the dropbox-sdk-spec or the Java Code Generator had.

This adds a baseline of the currently generated code. This could be noisy, but it's extremely useful to see the impact of config changes. Without this transparency, we are likely to see issues without knowing why.

This additionally adds a Github Action check to ensure that all generated code has been checked in, to ensure our baseline is always up to date.

Copy link
Contributor

@handstandsam handstandsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!!

This PR looks massive, but it's only changes to:

  • stone.gradle config
  • github actions to run "git status" clean check
  • script to run "git status" clean check

Feel free to merge once tests pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants