Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing typing stub packages for mypy #72

Merged
merged 1 commit into from Jun 23, 2021
Merged

Add missing typing stub packages for mypy #72

merged 1 commit into from Jun 23, 2021

Conversation

jayqi
Copy link
Member

@jayqi jayqi commented Jun 23, 2021

Fixes our failing build.

Putting it in make lint seems like the most straightforward solution since it's only required for mypy checks. Running it multiple times doesn't seem to add any overheard.

After reading through this very confusing thread, apparently this solution was recently implemented.

@jayqi jayqi requested a review from pjbull June 23, 2021 07:23
@github-actions
Copy link
Contributor

@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #72 (5a9c9f1) into master (fccb7dd) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master     #72   +/-   ##
======================================
  Coverage    98.1%   98.1%           
======================================
  Files           8       8           
  Lines         382     382           
======================================
  Hits          375     375           
  Misses          7       7           

@pjbull pjbull merged commit 3e9a1ed into master Jun 23, 2021
@pjbull pjbull deleted the jyq-fix-mypy branch June 23, 2021 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants