Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make stat a method on CloudPath class #250

Merged
merged 2 commits into from
Aug 18, 2022
Merged

Conversation

pjbull
Copy link
Member

@pjbull pjbull commented Aug 17, 2022

Make stat a method instead of a property to follow pathlib API.

Note: this is technically a potentially breaking change for anyone who implemented their own plugin CloudPath subclass, but didn't override stat. All of our classes override stat as a method properly.

Bonus fix for #203 since upstream breaking change was fixed we can unpin our pytest version

Fixes #234
Fixes #203

@github-actions
Copy link
Contributor

github-actions bot commented Aug 17, 2022

@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2022

Codecov Report

Merging #250 (db77d18) into master (4cc0d33) will decrease coverage by 0.1%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master    #250     +/-   ##
========================================
- Coverage    95.0%   94.8%   -0.2%     
========================================
  Files          21      21             
  Lines        1324    1323      -1     
========================================
- Hits         1258    1255      -3     
- Misses         66      68      +2     
Impacted Files Coverage Δ
cloudpathlib/cloudpath.py 93.5% <ø> (-0.5%) ⬇️

@pjbull pjbull merged commit 1f28327 into master Aug 18, 2022
@pjbull pjbull deleted the 234-fix-stat-signature branch August 18, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interface difference between CloudPath and its children Make test suite pass with pytest>=7.0
3 participants