Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip mtime checks during upload when force_overwrite_to_cloud is set #380

Merged
merged 3 commits into from
Dec 11, 2023
Merged

Skip mtime checks during upload when force_overwrite_to_cloud is set #380

merged 3 commits into from
Dec 11, 2023

Conversation

Gilthans
Copy link
Contributor

@Gilthans Gilthans commented Nov 7, 2023

Skip mtime checks when they aren't necessary to improve upload performance (especially when uploading many small files).

Closes #379

Contributor checklist:

  • [ V ] I have read and understood CONTRIBUTING.md
  • [ V ] Confirmed an issue exists for the PR, and the text Closes #issue appears in the PR summary (e.g., Closes #123).
  • [ V ] Confirmed PR is rebased onto the latest base
  • [ - ] Confirmed failure before change and success after change
  • [ - ] Any generic new functionality is replicated across cloud providers if necessary
  • [ - ] Tested manually against live server backend for at least one provider
  • [ - ] Added tests for any new functionality
  • [ V ] Linting passes locally
  • [ V ] Tests pass locally
  • [ V ] Updated HISTORY.md with the issue that is addressed and the PR you are submitting. If the top section is not `## UNRELEASED``, then you need to add a new section to the top of the document for your change.

@codecov Codecov
Copy link

codecov bot commented Nov 7, 2023 •
edited

Codecov Report

Merging #380 (aaca9ba) into master (945a352) will decrease coverage by 0.4%.
The diff coverage is 100.0%.

Additional details and impacted files 
@@           Coverage Diff            @@
##           master    #380     +/-   ##
========================================
- Coverage    93.6%   93.2%   -0.4%     
========================================
  Files          22      22             
  Lines        1563    1566      +3     
========================================
- Hits         1464    1461      -3     
- Misses         99     105      +6
Files Coverage Δ
cloudpathlib/cloudpath.py 91.9% <100.0%> (+<0.1%) ⬆️

... and 2 files with indirect coverage changes

@pjbull pjbull changed the base branch from master to 380-live-tests December 11, 2023 18:18
@pjbull pjbull merged commit 1be5354 into drivendataorg:380-live-tests Dec 11, 2023
26 of 28 checks passed
@pjbull pjbull mentioned this pull request Dec 11, 2023
Merged
10 tasks
pjbull added a commit that referenced this pull request Dec 11, 2023
@pjbull @Gilthans
Skip mtime checks during upload when force_overwrite_to_cloud is set (#…
41aa53d 
…380) (#384)

* Skip mtime checks during upload when force_overwrite_to_cloud is set

* Lint fix

* Updated HISTORY.md

Co-authored-by: Daniel Oriyan <gilthans@gmail.com>
@pjbull pjbull mentioned this pull request May 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid making mtime checks if force_overwrite_to_cloud is set
2 participants
@Gilthans @pjbull