Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid making mtime checks if force_overwrite_to_cloud is set #379

Closed
Gilthans opened this issue Nov 7, 2023 · 1 comment · Fixed by #380
Closed

Avoid making mtime checks if force_overwrite_to_cloud is set #379

Gilthans opened this issue Nov 7, 2023 · 1 comment · Fixed by #380

Comments

@Gilthans
Copy link
Contributor

Gilthans commented Nov 7, 2023

Hey there,
I noticed that when uploading files, even if force_overwrite_to_cloud is set, local + cloud mtime of the file are still calculated, even though they are effectively ignored.
Usually this is a minor performance overhead, but it can have a large impact when uploading a directory with many small files (like an image pyramid for example).
Since this does not affect functionality at all, I think this is an easy win!

I'll submit a PR soon, LMK if I missed anything

@pjbull
Copy link
Member

pjbull commented May 26, 2024

Fixed by #380.

@pjbull pjbull closed this as completed May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants