Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make test suite pass with pytest>=7.0 #203

Closed
pjbull opened this issue Feb 5, 2022 · 0 comments · Fixed by #250
Closed

Make test suite pass with pytest>=7.0 #203

pjbull opened this issue Feb 5, 2022 · 0 comments · Fixed by #250
Labels
good first issue Good for newcomers

Comments

@pjbull
Copy link
Member

pjbull commented Feb 5, 2022

In #202 we added a dev requirement to use pytest<7.0 since the test suite was breaking with the latest pytest version.

Looks like a compatibility issue with pytest-cases:
smarie/python-pytest-cases#251

Here's the stack trace:

__________________________________________________________________________________________________________________________________________________________________ ERROR collecting tests/test_s3_specific.py __________________________________________________________________________________________________________________________________________________________________
../../miniconda3/envs/cloudpathlib/lib/python3.8/site-packages/pluggy/_hooks.py:265: in __call__
    return self._hookexec(self.name, self.get_hookimpls(), kwargs, firstresult)
../../miniconda3/envs/cloudpathlib/lib/python3.8/site-packages/pluggy/_manager.py:80: in _hookexec
    return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
../../miniconda3/envs/cloudpathlib/lib/python3.8/site-packages/_pytest/python.py:257: in pytest_pycollect_makeitem
    res = list(collector._genfunctions(name, obj))
../../miniconda3/envs/cloudpathlib/lib/python3.8/site-packages/_pytest/python.py:487: in _genfunctions
    fixtures.add_funcarg_pseudo_fixture_def(self, metafunc, fm)
../../miniconda3/envs/cloudpathlib/lib/python3.8/site-packages/_pytest/fixtures.py:164: in add_funcarg_pseudo_fixture_def
    if not metafunc._calls[0].funcargs:
../../miniconda3/envs/cloudpathlib/lib/python3.8/site-packages/pytest_cases/plugin.py:931: in __getitem__
    return self.calls_list[item]
../../miniconda3/envs/cloudpathlib/lib/python3.8/site-packages/pytest_cases/plugin.py:942: in calls_list
    self.create_call_list_from_pending_parametrizations()
../../miniconda3/envs/cloudpathlib/lib/python3.8/site-packages/pytest_cases/plugin.py:994: in create_call_list_from_pending_parametrizations
    remove_empty_ids(callspec)
../../miniconda3/envs/cloudpathlib/lib/python3.8/site-packages/pytest_cases/fixture_parametrize_plus.py:556: in remove_empty_ids
    callspec._idlist = [c for c in callspec._idlist if not c.startswith(EMPTY_ID)]
../../miniconda3/envs/cloudpathlib/lib/python3.8/site-packages/attr/_make.py:626: in _frozen_setattrs
    raise FrozenInstanceError()
E   attr.exceptions.FrozenInstanceError

Originally posted by @jayqi in #202 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant