Update README.md with available sets #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterfox
approved these changes
May 7, 2024
There was a problem hiding this comment.
Thanks @GeniJaho, this looks good to me.
I did float a solution for this in the main Rector repo but just haven't had the time/energy. It would be good to automate it all but for now I think this displays the options nicely.
|
The table in the Readme is quite bigger than I thought, will fix it soon 😅. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new section in the Readme, since it's not obvious what the available Laravel sets are, what they do, and why.
Descriptions and links are taken from the comments in the rules/sets themselves, but we may need more descriptive paragraphs. @driftingly @peterfox what do you think?
I've also added two new constants to
LaravelSetList, since we have the sets but they can't be used at all without their constants:Sets were added in #192 and #194.