Updating to 1.18 and updating dependencies #1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
a minor note is that the Dockerfiles and test-integration modules file are still 1.17 |
CluEleSsUK
reviewed
Aug 24, 2022
CluEleSsUK
reviewed
Aug 24, 2022
nikkolasg
previously approved these changes
Aug 27, 2022
CluEleSsUK
reviewed
Aug 29, 2022
CluEleSsUK
reviewed
Aug 29, 2022
CluEleSsUK
previously approved these changes
Aug 29, 2022
CluEleSsUK
previously approved these changes
Aug 29, 2022
CluEleSsUK
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fixing many issues we faced when trying to update our dependencies:
grpc.WithInsecurewas deprecatedInterestingly, we are currently not able to update to:
Because the former is not currently compatible with how
github.com/weaveworks/common/httpgrpc/serveris using it, and the latter had some breaking changes in how it handlesomitemptycomparison that currently panic in our codebase (BurntSushi/toml#360). It will need more care.