Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDPA-5029] data table component #926

Merged
merged 25 commits into from
Apr 19, 2021
Merged

[SDPA-5029] data table component #926

merged 25 commits into from
Apr 19, 2021

Conversation

rubyllamadora
Copy link
Contributor

@rubyllamadora rubyllamadora commented Mar 31, 2021 •
edited

Motivation and Context

JIRA issue: https://digital-engagement.atlassian.net/browse/SDPA-5029
Design: https://www.figma.com/file/yU8WxRblqGrrC7QZEcZAsw/CMS-component-wireframes?node-id=1585%3A2

Changed

  1. Added new DataTable component
  2. Added storybook docco
  3. Added unit test

https://app.pr-926.ripple.sdp1.sdp.vic.gov.au/
Docco here https://storybook.pr-926.ripple.sdp1.sdp.vic.gov.au/?path=/story/molecules-datatable--row-oriented-mobile-layout#datatable

Screenshots

Single column mobile layout
image

Two column mobile layout
image

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist

  • I've added relevant changes to the documentation.
  • I have added tests to cover my changes (if not applicable, please state why)
  • My change requires a template update for create-ripple-app.
  • I have added template update script for next release.

@rubyllamadora rubyllamadora self-assigned this Mar 31, 2021
@rubyllamadora rubyllamadora marked this pull request as ready for review April 11, 2021 23:41
@tim-yao tim-yao self-requested a review April 12, 2021 22:35
tim-yao
tim-yao approved these changes Apr 12, 2021
View reviewed changes
Copy link
Contributor

@tim-yao tim-yao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good! Thanks @rubyllamadora !

@MdNadimHossain MdNadimHossain merged commit 1f21b58 into develop Apr 19, 2021
@MdNadimHossain MdNadimHossain deleted the feature/SDPA-5029-data-table-component branch April 19, 2021 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MdNadimHossain MdNadimHossain Awaiting requested review from MdNadimHossain

@tim-yao tim-yao Awaiting requested review from tim-yao

Assignees

@rubyllamadora rubyllamadora

Labels
Needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rubyllamadora @tim-yao @MdNadimHossain