Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow http dependency v5+ #15

Merged
merged 2 commits into from Dec 14, 2022
Merged

Allow http dependency v5+ #15

merged 2 commits into from Dec 14, 2022

Conversation

jeffgran-dox
Copy link
Contributor

http version 5 is out, with the following breaking changes, according to their changelog:


  • For the first: I searched for references to header and did not find anywhere we are relying on header case
  • For the second: I searched for .parse and did not find anywhere we are calling Response#parse
  • The third did break one test. Looking at the related PR, I saw this comment explaining why it was a breaking change:

    This is a breaking change for integrators like WebMock for example.
    Updating webmock fixed the test.

Therefore I believe it is safe to allow v5.

@jeffgran-dox jeffgran-dox marked this pull request as ready for review December 14, 2022 20:05
@jeffgran-dox jeffgran-dox merged commit b217a87 into master Dec 14, 2022
@jeffgran-dox jeffgran-dox deleted the jg/allow-http-v5 branch December 14, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants