Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 'WinFx' -> 'WinFX' casing #2975

Merged
merged 6 commits into from
Jun 10, 2020
Merged

Update 'WinFx' -> 'WinFX' casing #2975

merged 6 commits into from
Jun 10, 2020

Conversation

Nirmal4G
Copy link
Contributor

@Nirmal4G Nirmal4G commented May 10, 2020 •
edited

As the title suggests, This PR renames WinFx to WinFX where possible except in the sources (e.g.: GetWinFxCallback).

I've separated out the new-line and white-space changes to a separate commits.
Only files that were touched with WinFX casing changes are updated with formatting changes.
If it's not possible to merge and/or if you want the line & space changes applied to the whole repo, please let me know, I'll separate these into a new PR.

Related: dotnet/msbuild#5346

The casing could also be updated for WPF (.NET Framework) targets and sources.

@Nirmal4G
Rename 'Microsoft.WinFx.targets' to 'Microsoft.WinFX.targets'
52cfaf6 
'WinFX' is the correct casing as observed in the .NET CLR 2 frameworks
@Nirmal4G
Fix 'WinFx' -> 'WinFX' everywhere else
e424bed 
In project files, scripts, comments, etc...
But not in sources (like GetWinFxCallback)
@Nirmal4G
NewLine fixes for only previously changed files
9cc53b1 
Conforming to the repository's EditorConfig file
IN this Patch tree
@Nirmal4G
Update & Format EditorConfig
7cdf7a8 
Add 'trim_trailing_whitespace' to EditorConfig
@Nirmal4G
Remove all trailing whitespaces
5b07c93 
for only previously changed files (in this Patch tree)
Conforming to the repository's EditorConfig file
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label May 10, 2020
@ghost ghost requested review from fabiant3, ryalanms and SamBent May 10, 2020 21:30
@Nirmal4G
Copy link
Contributor Author

Nirmal4G commented May 10, 2020 •
edited

Supersedes #2877

Fixes novotnyllc/MSBuildSdkExtras#224

@Nirmal4G Nirmal4G marked this pull request as ready for review May 10, 2020 21:48
@Nirmal4G Nirmal4G requested a review from a team as a code owner May 10, 2020 21:48
@Nirmal4G Nirmal4G mentioned this pull request May 10, 2020
Closed
@Nirmal4G Nirmal4G changed the title Fix 'WinFx' -> 'WinFX' casing Update 'WinFx' -> 'WinFX' casing May 10, 2020
@Nirmal4G Nirmal4G mentioned this pull request May 11, 2020
Open
@moljac
Copy link

moljac commented May 11, 2020

This is due to testing on case insensitive filesystems like Windows and Mac default AFS.

I think this should be fixed in the templates in the MsBuild.Extras.

And BTW you are breaking framework design guidelines in respect to naming.
WinFx can never be WinFX.
(Sorry, but I had to be mean/cynical/sarcastic).

@Nirmal4G
Copy link
Contributor Author

Nirmal4G commented May 11, 2020 •
edited

@moljac

And BTW you are breaking framework design guidelines in respect to naming.

It's like WinRT, WinAPI, etc... There are special cases. Casing is important, It represents the product.

The Microsoft.NET.Sdk.WindowsDesktop is owned by the WPF team. The original casing is WinFX and not WinFx. It was only changed in the NETCLR 4 builds. I don't know how or why but all target files are jumbled up in casing for comments, properties and filenames. They might've used a formatter but did not consider for the special cases.

I think this should be fixed in the templates in the MSBuild.Sdk.Extras.

Extras SDK merely extends the preinstalled SDKs. There is no direct reference to these files in the Extras SDK.

This was referenced Jun 4, 2020
Closed
Open
@Nirmal4G
Copy link
Contributor Author

Nirmal4G commented Jun 4, 2020

It seems this also fixes the case where people using case-sensitive file-system that would result in file not found error because of the incorrect casing in the files on disk.

@ryalanms
Copy link
Member

ryalanms commented Jun 8, 2020

Thank you for the fix, @Nirmal4G. Your casing commits have been separated and moved to another PR.

@ryalanms ryalanms mentioned this pull request Jun 8, 2020
Merged
@Nirmal4G
Copy link
Contributor Author

Nirmal4G commented Jun 9, 2020

@ryalanms Is there any issue with this PR, not being mergable?

@ryalanms
Copy link
Member

@Nirmal4G: No issues. We can take these formatting changes now. Thanks.

@Nirmal4G
Update from master
c4836eb 
Fix all conflicts
@Nirmal4G
Copy link
Contributor Author

@ryalanms Fixed all conflicts. You can merge them now.

@ryalanms ryalanms merged commit 0a3e920 into dotnet:master Jun 10, 2020
@Nirmal4G Nirmal4G deleted the hotfix/fix-WinFX-casing branch June 10, 2020 19:06
@Nirmal4G Nirmal4G mentioned this pull request Jun 13, 2020
Closed
This was referenced Mar 7, 2021
Open
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Apr 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryalanms ryalanms ryalanms approved these changes

@fabiant3 fabiant3 Awaiting requested review from fabiant3

@SamBent SamBent Awaiting requested review from SamBent

Assignees
No one assigned
Labels
PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Nirmal4G @moljac @ryalanms