Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed localization of templates #250

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vlada-shubina
Copy link
Member

#220 enabled localization only for one project. Enabled it also for others.

Please onboard repo to OneLocBuild to get the templates localized: https://aka.ms/AllAboutLoc

@vlada-shubina vlada-shubina mentioned this pull request Sep 8, 2022
@Evangelink
Copy link
Member

@vlada-shubina I don't know much about this change. Are you confident so I can merge "blindly"? Or shall I try to get feedback from someone else?

@Evangelink
Copy link
Member

Ping @vlada-shubina

@vlada-shubina
Copy link
Member Author

vlada-shubina commented Nov 21, 2022

The change itself is safe, but you need to onboard the repo for localization, if not yet configured.
The info is here: https://aka.ms/AllAboutLoc, you need to create ticket and loc people will get in touch. Please let them know that this is for templates localization. Otherwise the localization files will be generated, but never translated.

@vlada-shubina
Copy link
Member Author

@jonfortescue - do we need to do anything else from arcade standpoint for templates localization? test-templates is on arcade, and i see the scrips in the eng folder contain the logic for templates localization.

@Evangelink
Copy link
Member

cc @cvpoienaru

@jonfortescue
Copy link
Member

@vlada-shubina I think just making sure to add the OneLocBuild template to the main pipeline would be it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants