Clean up contents from previously-sb tarball post binary-cleanup #40772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
ViktorHofer
added
source-build
Area-VMR
and removed
Area-Infrastructure
untriaged
MichaelSimons
approved these changes
May 8, 2024
|
@omajid - there was a conflicting change made today. Can you please resolve the conflicts? TIA. |
If we extracted the previously-source-build tarball only for running the binary cleanup tool, clean up the extracted contents. This undo's the extraction operation that was only performed for running the binary-cleanup tool. I am creating a tarball for building .NET offline post-prep. In that scenario, I run ./prep-source-build.sh --bootstrap, and then package up the entire VMR directory into a tarball. Without this cleanup, there are a ton of duplicated binaries in the tarball, since the nuget packages are both in previously-source-built archive and in an extracted form. With this change, the archive size goes from just over 4GB to just over 2GB. This is a port of dotnet/installer#19632 from installer repo to sdk.
omajid
force-pushed
the
prep-remove-extracted-tarball-packages-post-binary-cleanup
branch
from
0cc0768
to
8038487
Compare
omajid
commented
May 8, 2024
ellahathaway
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we extracted the previously-source-build tarball only for running the binary cleanup tool, clean up the extracted contents. This undo's the extraction operation that was only performed for running the binary-cleanup tool.
I am creating a tarball for building .NET offline post-prep. In that scenario, I run ./prep-source-build.sh --bootstrap, and then package up the entire VMR directory into a tarball. Without this cleanup, there are a ton of duplicated binaries in the tarball, since the nuget packages are both in previously-source-built archive and in an extracted form. With this change, the archive size goes from just over 4GB to just over 2GB.
This is a port of dotnet/installer#19632 from installer to sdk.