Implement remaining ILGenertorImpl methods, excluding scope. Add max stack calculation for branching. #96362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/area-system-reflection-emit Issue Details
Contributes to #92975
|
20 tasks
This was referenced Dec 30, 2023
steveharter
approved these changes
Dec 30, 2023
| public override void UsingNamespace(string usingNamespace) => throw new NotImplementedException(); | ||
| public override void UsingNamespace(string usingNamespace) | ||
| { | ||
| // TODO: No-op, will be implemented wit PDB support |
src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/AssemblyBuilderImpl.cs
Show resolved
Hide resolved
src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/ILGeneratorImpl.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/ILGeneratorImpl.cs
Show resolved
Hide resolved
| ilg.Emit(OpCodes.Ldarg_0); | ||
| ilg.Emit(OpCodes.Brfalse, lab); | ||
|
|
||
| // The label is marked with a larger stack depth, one. This IL is invalid. |
There was a problem hiding this comment.
So we don't detect \ throw on these cases, and CreateTypeInfo() doesn't either?
There was a problem hiding this comment.
These tests are imported from runtime ILGenerator tests
Personally, I am not sure this exact test makes sense, though runtime doesn't detect or throw ...
|
Note the test error: |
src/libraries/System.Reflection.Emit/src/Resources/Strings.resx
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emit(OpCode opcode, SignatureHelper signature),EmitCalli(OpCode opcode, CallingConvention unmanagedCallConv, Type? returnType, Type[]? parameterTypes)andEmitCalli(OpCode opcode, CallingConventions callingConvention, Type? returnType, Type[]? parameterTypes, Type[]? optionalParameterTypes)method+optionalParametersreference scenario, also refactored/fixed allModuleBuilder.Get***MetadataTokenimplementations as neededNotImplementedException) forBeginScope(),EndScope()andUsingNamespace(string usingNamespace), their implementations will be added with PDB support.BadImageFormatExceptionwhen loading generated assemblies withAssembly.LoadFrom(path)for run. Some tests now run the loaded assembly.Contributes to #92975