Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit exception blocks for the new ILGenerator #94366

Merged
merged 2 commits into from Nov 14, 2023
Merged

Emit exception blocks for the new ILGenerator #94366

merged 2 commits into from Nov 14, 2023

Conversation

buyaa-n
Copy link
Member

@buyaa-n buyaa-n commented Nov 3, 2023

Adds implementation for Label BeginExceptionBlock(), BeginCatchBlock(Type? exceptionType), BeginExceptFilterBlock(), BeginFinallyBlock(), BeginFaultBlock() and EndExceptionBlock() for the new ILGenerator implementation.

Contributes to #92975

@ghost ghost assigned buyaa-n Nov 3, 2023
@ghost
Copy link

ghost commented Nov 3, 2023

Tagging subscribers to this area: @dotnet/area-system-reflection-emit
See info in area-owners.md if you want to be subscribed.

Issue Details

Adds implementation for Label BeginExceptionBlock(), BeginCatchBlock(Type? exceptionType), BeginExceptFilterBlock(), BeginFinallyBlock(), BeginFaultBlock() and EndExceptionBlock() for the new ILGenerator implementation.

Contributes to #92975

Author: buyaa-n
Assignees: -
Labels:

area-System.Reflection.Emit
Milestone: -

@buyaa-n buyaa-n mentioned this pull request Nov 4, 2023
Closed
20 tasks
AaronRobinsonMSFT
AaronRobinsonMSFT reviewed Nov 4, 2023
View reviewed changes
Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a specific reference you are using?

src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/ILGeneratorImpl.cs Outdated Show resolved Hide resolved
src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/ILGeneratorImpl.cs Show resolved Hide resolved
src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/ILGeneratorImpl.cs Outdated Show resolved Hide resolved
src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/ILGeneratorImpl.cs Outdated Show resolved Hide resolved
src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/ILGeneratorImpl.cs Outdated Show resolved Hide resolved
src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/ILGeneratorImpl.cs Outdated Show resolved Hide resolved
@buyaa-n
Copy link
Member Author

buyaa-n commented Nov 6, 2023 •
edited

Is there a specific reference you are using?

Existing RuntimeILGenerator, ECMA-335 spec, area experts, Reflection.Emit and Reflection.MetadataBuilder docs, SharpLab, ILSPy etc which ever I could find

jkotas
jkotas approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@buyaa-n buyaa-n merged commit 6ffa548 into dotnet:main Nov 14, 2023
109 checks passed
@buyaa-n buyaa-n deleted the exception branch November 14, 2023 16:20
@github-actions github-actions bot locked and limited conversation to collaborators Dec 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT left review comments

@jkotas jkotas jkotas approved these changes

@steveharter steveharter Awaiting requested review from steveharter

Assignees

@buyaa-n buyaa-n

Labels
area-System.Reflection.Emit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@buyaa-n @jkotas @AaronRobinsonMSFT