Add Label support in new ILGenerator #93565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Aaron Robinson <arobins@microsoft.com>
…t/ILGeneratorImpl.cs Co-authored-by: Aaron Robinson <arobins@microsoft.com>
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
|
Tagging subscribers to this area: @dotnet/area-system-reflection-emit Issue DetailsAdd implementation for The PR depend on #93244, will be cleaned up after #93244 merged. Also blocked by #93497. Contributes to #92975
|
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
20 tasks
jkotas
approved these changes
Oct 26, 2023
src/libraries/System.Reflection.Emit.ILGeneration/tests/Label/LabelId.cs
Outdated
Show resolved
Hide resolved
AaronRobinsonMSFT
approved these changes
Oct 26, 2023
This was referenced Oct 26, 2023
|
The failure is known |
liveans
pushed a commit
to liveans/dotnet-runtime
that referenced
this pull request
Nov 9, 2023
* Emit Label/Branching IL * Throw when OpCode is not Switch Co-authored-by: Jan Kotas <jkotas@microsoft.com> * Add protected factory to ILGenerator instead of making the Label constructor public * Update test to assert label.Id instead of label.GetHashCode --------- Co-authored-by: Jan Kotas <jkotas@microsoft.com>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add implementation for
DefineLabel(),(OpCode opcode, Label label),Emit(OpCode opcode, Label[] labels),MarkLabel(Label loc)and corresponding testsContributes to #92975 and #93497