[VM] Fix potential double free #86207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a raw char `NewArrayHolder` instead of a `NewHolder` to store the `StackingAllocator` to prevent its destructor from being called twice since `StackingAllocatorHolder` has already taken care of the destruction.
ghost
added
the
community-contribution
yowl
pushed a commit
to yowl/runtime
that referenced
this pull request
May 13, 2023
* Add a regression test for dotnet#86207 * Ensure RotateRight and RotateLeft decomposition orders parameters correctly * Add explicit tests covering the other two DecomposeRotate paths * Ensure other code paths that create GT_RSH_LO nodes aren't broken
mangod9
approved these changes
Jun 5, 2023
|
Thanks for your contribution! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a raw char
NewArrayHolderinstead of aNewHolderto store theStackingAllocatorto prevent its destructor from being called twice sinceStackingAllocatorHolderhas already taken care of the destruction.This fixes a double free error when
ACQUIRE_STACKING_ALLOCATORis called in environments/OSes with smaller per-thread stack sizes, such as in this port.