Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made FormattedLogValues public #85859

Closed

Conversation

abatishchev
Copy link
Contributor

@abatishchev abatishchev commented May 6, 2023

Resolves #67577. Reverts dotnet/extensions#513 which made it internal.

Made struct src/libraries/Microsoft.Extensions.Logging.Abstractions/src/FormattedLogValues public again to simplify mocking and other kinds of testing. See #67577 for more details and examples.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label May 6, 2023
@ghost
Copy link

ghost commented May 6, 2023

Tagging subscribers to this area: @dotnet/area-extensions-logging
See info in area-owners.md if you want to be subscribed.

Issue Details

Resolves #67577.

Author: abatishchev
Assignees: -
Labels:

area-Extensions-Logging, community-contribution

Milestone: -

@stephentoub
Copy link
Member

Thanks for the interest in contributing. While the comments on the issue were likely misleading in this regard, we don't add new public API until they've been through API review, and this hasn't yet. Closing for now.

https://github.com/dotnet/runtime/blob/main/docs/project/api-review-process.md

@stephentoub stephentoub closed this May 6, 2023
@abatishchev abatishchev deleted the alexbat/public-FormattedLogValues branch May 6, 2023 13:24
@abatishchev
Copy link
Contributor Author

Fair. Will follow the discussion and reopen when ready.

@ghost ghost locked as resolved and limited conversation to collaborators Jun 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Extensions-Logging community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FormattedLogValues struct should be public
2 participants