Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit warning instead of an error in package compatibility check #72518

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Jul 20, 2022

Based on the conversation happening in open-telemetry/opentelemetry-dotnet#3448, we want to emit a warning instead of an error on unsupported target frameworks. We still explicitly indicate that this is an unsupported scenario but don't actively block consumers anymore and also print how to suppress the warning.

cc @andrewlock

Based on the discussed in open-telemetry/opentelemetry-dotnet#3448, we are now emitting a warning instead of an error on unsupported target frameworks. We still explicitly indicate that this is an unsupported scenario but don't actively block consumers anymore and also indicate how to suppress the warning.
@ViktorHofer ViktorHofer added the packaging Related to packaging label Jul 20, 2022
@ViktorHofer ViktorHofer added this to the 7.0.0 milestone Jul 20, 2022
@ViktorHofer ViktorHofer self-assigned this Jul 20, 2022
@ghost
Copy link

ghost commented Jul 20, 2022

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Based on the discussed in open-telemetry/opentelemetry-dotnet#3448, we are now emitting a warning instead of an error on unsupported target frameworks. We still explicitly indicate that this is an unsupported scenario but don't actively block consumers anymore and also indicate how to suppress the warning.

cc @andrewlock

Author: ViktorHofer
Assignees: ViktorHofer
Labels:

area-Infrastructure-libraries, packaging

Milestone: 7.0.0

@ViktorHofer
Copy link
Member Author

@noahfalk can you please approve?

Copy link
Member

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ViktorHofer ViktorHofer merged commit 336317a into main Jul 26, 2022
@ViktorHofer ViktorHofer deleted the ViktorHofer-patch-2 branch July 26, 2022 13:35
@ghost ghost locked as resolved and limited conversation to collaborators Aug 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants