Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm][wbt] Test that
dotnet.js
could be run from any current directory #69441[wasm][wbt] Test that
dotnet.js
could be run from any current directory #69441Changes from 6 commits
d5f10f5
2db7974
2952c7b
3922e05
d651c70
2f1c9eb
b6804be
5a94685
930c701
eb07469
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think of creating this tmpBundleDir in a completely different location, like under
Path.GetTempPath()
? This would ensure that it isn't dependent on anything in the binDir.And make sure to add
id
, and the project name to the dir name, so the different runs don't overlap.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a good method in Node and V8 environments!
I' ll change that style.
However, browsers like Chrome cannot explore the parent directory, so I would like to keep the current style.