Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add hooks to debug OpenSSL memory #101626
base: main
Are you sure you want to change the base?
add hooks to debug OpenSSL memory #101626
Changes from 12 commits
a163dbf
9b5b3d3
ea6ac3f
0338b06
8744c2d
401178f
803fc94
cd55d63
638df97
dd9b017
d42f271
01f556f
173827a
a86c713
c0838ea
60e933e
7c03ee3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 176 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Crypto.cs
Azure Pipelines / runtime (Build linux-riscv64 Release AllSubsets_Mono)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Crypto.cs#L176
Check failure on line 176 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Crypto.cs
Azure Pipelines / runtime (Build linux_musl-x64 Release AllSubsets_Mono)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Crypto.cs#L176
Check failure on line 176 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Crypto.cs
Azure Pipelines / runtime (Build android-arm Release AllSubsets_Mono)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Crypto.cs#L176
Check failure on line 176 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Crypto.cs
Azure Pipelines / runtime (Build linux-x64 Release AllSubsets_Mono_LLVMAOT)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Crypto.cs#L176
Check failure on line 176 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Crypto.cs
Azure Pipelines / runtime (Build android-arm64 Release AllSubsets_Mono)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Crypto.cs#L176
Check failure on line 176 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Crypto.cs
Azure Pipelines / runtime (Build linux-arm64 Release NativeAOT_Libraries)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Crypto.cs#L176
Check failure on line 176 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Crypto.cs
Azure Pipelines / runtime (Build linux-arm64 Release AllSubsets_Mono_LLVMAOT)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Crypto.cs#L176
Check failure on line 176 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Crypto.cs
Azure Pipelines / runtime (Build linux_musl-arm Debug AllSubsets_CoreCLR_ReleaseRuntimeLibs)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Crypto.cs#L176
Check failure on line 176 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Crypto.cs
Azure Pipelines / runtime (Build linux-arm Debug AllSubsets_CoreCLR_ReleaseRuntimeLibs)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Crypto.cs#L176
Check failure on line 176 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Crypto.cs
Azure Pipelines / runtime (Build linux_musl-arm64 Debug AllSubsets_CoreCLR_ReleaseRuntimeLibs)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Crypto.cs#L176
Check failure on line 176 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Crypto.cs
Azure Pipelines / dotnet-linker-tests (Build linux-x64 release Runtime_Release)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Crypto.cs#L176
Check failure on line 176 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Crypto.cs
Azure Pipelines / dotnet-linker-tests
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Crypto.cs#L176
Check failure on line 176 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Crypto.cs
Azure Pipelines / runtime
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Crypto.cs#L176
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using ConcurrentDictionary<UIntPtr, something> would allow us to remove some of the locks and reduce contention.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understood the original comment from @jkotas, then this is still a potential problem
#101626 (comment)
Or does that hold only for the malloc/free calls and not GC-allocated memory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not safe to use any managed code if this can be called from places like thread destructor. #101626 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right. I split the change now into two parts. The basic counters are implemented in native as @janvorli suggested. That also eliminates need to fiddle with the crypto initialization.
Now for the managed part. I made this whole section
#if DEBUG
for now to limit the exposure. While this limits use in production it would allow us to experiment more and perhaps hook it to test runs. I'm yet to see case where it actually fails. Since this can be set during run for some particular operation(s) it may avoid the cases we are concern about e.g. threads operations. AFAIK there is API to get loaded providers so we may for example check FIPS or 3rd party modules.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check failure on line 60 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build wasi-wasm linux Release LibraryTests_Smoke_AOT)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L60
Check failure on line 60 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build wasi-wasm linux Release LibraryTests_Smoke)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L60
Check failure on line 60 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build linux-x64 Debug Mono_Interpreter_LibrariesTests)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L60
Check failure on line 60 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build tvos-arm64 Release AllSubsets_Mono)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L60
Check failure on line 60 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build linux-arm64 Debug Mono_MiniJIT_LibrariesTests)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L60
Check failure on line 60 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build linux-x64 Debug Mono_MiniJIT_LibrariesTests)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L60
Check failure on line 60 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime-dev-innerloop (Build linux-x64 debug Libraries_AllConfigurations)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L60
Check failure on line 60 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build browser-wasm linux Release LibraryTests_Smoke_AOT)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L60
Check failure on line 60 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build browser-wasm linux Release LibraryTests)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L60
Check failure on line 60 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build browser-wasm linux Release LibraryTests_EAT)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L60
Check failure on line 60 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build browser-wasm linux Release LibraryTests_Threading)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L60
Check failure on line 60 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build linux_musl-x64 Debug CoreCLR_Libraries)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L60
Check failure on line 60 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build ios-arm64 Release AllSubsets_NativeAOT)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L60
Check failure on line 60 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build ios-arm64 Release AllSubsets_Mono)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L60
Check failure on line 60 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build osx-x64 Release AllSubsets_Mono_LLVMJIT)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L60
Check failure on line 60 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build linux-x64 Debug CoreCLR_Libraries)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L60
Check failure on line 60 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build osx-x64 Debug AllSubsets_Mono_LLVMAOT)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L60
Check failure on line 60 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build osx-x64 Debug Mono_MiniJIT_LibrariesTests)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L60
Check failure on line 60 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build maccatalyst-x64 Release AllSubsets_Mono)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L60
Check failure on line 60 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build linux-arm64 Debug Libraries_CheckedCoreCLR)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L60
Check failure on line 60 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build tvos-arm64 Release AllSubsets_NativeAOT)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L60
Check failure on line 60 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build osx-arm64 Release NativeAOT_Libraries)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L60
Check failure on line 60 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime-dev-innerloop
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L60
Check failure on line 60 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build osx-x64 Debug CoreCLR_Libraries)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L60
Check failure on line 60 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build osx-arm64 Debug AllSubsets_CoreCLR)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L60
Check failure on line 60 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build osx-x64 Debug Libraries_CheckedCoreCLR)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L60
Check failure on line 60 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / dotnet-linker-tests (Build osx-x64 release Runtime_Release)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L60
Check failure on line 60 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / dotnet-linker-tests
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L60
Check failure on line 61 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build wasi-wasm linux Release LibraryTests_Smoke_AOT)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L61
Check failure on line 61 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build wasi-wasm linux Release LibraryTests_Smoke)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L61
Check failure on line 61 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build linux-x64 Debug Mono_Interpreter_LibrariesTests)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L61
Check failure on line 61 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build tvos-arm64 Release AllSubsets_Mono)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L61
Check failure on line 61 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build linux-arm64 Debug Mono_MiniJIT_LibrariesTests)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L61
Check failure on line 61 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build linux-x64 Debug Mono_MiniJIT_LibrariesTests)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L61
Check failure on line 61 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime-dev-innerloop (Build linux-x64 debug Libraries_AllConfigurations)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L61
Check failure on line 61 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build browser-wasm linux Release LibraryTests_Smoke_AOT)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L61
Check failure on line 61 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build browser-wasm linux Release LibraryTests)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L61
Check failure on line 61 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build browser-wasm linux Release LibraryTests_EAT)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L61
Check failure on line 61 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build browser-wasm linux Release LibraryTests_Threading)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L61
Check failure on line 61 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build linux_musl-x64 Debug CoreCLR_Libraries)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L61
Check failure on line 61 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build ios-arm64 Release AllSubsets_NativeAOT)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L61
Check failure on line 61 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build ios-arm64 Release AllSubsets_Mono)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L61
Check failure on line 61 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build osx-x64 Release AllSubsets_Mono_LLVMJIT)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L61
Check failure on line 61 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build linux-x64 Debug CoreCLR_Libraries)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L61
Check failure on line 61 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build osx-x64 Debug AllSubsets_Mono_LLVMAOT)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L61
Check failure on line 61 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build osx-x64 Debug Mono_MiniJIT_LibrariesTests)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L61
Check failure on line 61 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build maccatalyst-x64 Release AllSubsets_Mono)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L61
Check failure on line 61 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build linux-arm64 Debug Libraries_CheckedCoreCLR)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L61
Check failure on line 61 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build tvos-arm64 Release AllSubsets_NativeAOT)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L61
Check failure on line 61 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build osx-arm64 Release NativeAOT_Libraries)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L61
Check failure on line 61 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime-dev-innerloop
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L61
Check failure on line 61 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build osx-x64 Debug CoreCLR_Libraries)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L61
Check failure on line 61 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build osx-arm64 Debug AllSubsets_CoreCLR)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L61
Check failure on line 61 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build osx-x64 Debug Libraries_CheckedCoreCLR)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L61
Check failure on line 61 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / dotnet-linker-tests (Build osx-x64 release Runtime_Release)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L61
Check failure on line 63 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build linux-x64 Debug Mono_Interpreter_LibrariesTests)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L63
Check failure on line 63 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build linux-arm64 Debug Mono_MiniJIT_LibrariesTests)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L63
Check failure on line 63 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build linux-x64 Debug Mono_MiniJIT_LibrariesTests)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L63
Check failure on line 63 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime-dev-innerloop (Build linux-x64 debug Libraries_AllConfigurations)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L63
Check failure on line 63 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build linux_musl-x64 Debug CoreCLR_Libraries)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L63
Check failure on line 63 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build linux-x64 Debug CoreCLR_Libraries)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L63
Check failure on line 63 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build osx-x64 Debug AllSubsets_Mono_LLVMAOT)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L63
Check failure on line 63 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build osx-x64 Debug Mono_MiniJIT_LibrariesTests)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L63
Check failure on line 63 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build linux-arm64 Debug Libraries_CheckedCoreCLR)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L63
Check failure on line 63 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime-dev-innerloop
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L63
Check failure on line 63 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build osx-x64 Debug CoreCLR_Libraries)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L63
Check failure on line 63 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build osx-arm64 Debug AllSubsets_CoreCLR)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L63
Check failure on line 63 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build osx-x64 Debug Libraries_CheckedCoreCLR)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L63
Check failure on line 64 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build linux-x64 Debug Mono_Interpreter_LibrariesTests)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L64
Check failure on line 64 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build linux-arm64 Debug Mono_MiniJIT_LibrariesTests)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L64
Check failure on line 64 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build linux-x64 Debug Mono_MiniJIT_LibrariesTests)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L64
Check failure on line 64 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime-dev-innerloop (Build linux-x64 debug Libraries_AllConfigurations)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L64
Check failure on line 64 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build linux_musl-x64 Debug CoreCLR_Libraries)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L64
Check failure on line 64 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build linux-x64 Debug CoreCLR_Libraries)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L64
Check failure on line 64 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build osx-x64 Debug AllSubsets_Mono_LLVMAOT)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L64
Check failure on line 64 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build osx-x64 Debug Mono_MiniJIT_LibrariesTests)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L64
Check failure on line 64 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build linux-arm64 Debug Libraries_CheckedCoreCLR)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L64
Check failure on line 64 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime-dev-innerloop
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L64
Check failure on line 64 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build osx-x64 Debug CoreCLR_Libraries)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L64
Check failure on line 64 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build osx-arm64 Debug AllSubsets_CoreCLR)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L64
Check failure on line 64 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build osx-x64 Debug Libraries_CheckedCoreCLR)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L64
Check failure on line 65 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build linux-x64 Debug Mono_Interpreter_LibrariesTests)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L65
Check failure on line 65 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime-dev-innerloop (Build linux-x64 debug Libraries_AllConfigurations)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L65
Check failure on line 65 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build osx-x64 Debug Mono_MiniJIT_LibrariesTests)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L65
Check failure on line 65 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build linux-arm64 Debug Libraries_CheckedCoreCLR)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L65
Check failure on line 65 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build osx-x64 Debug CoreCLR_Libraries)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L65
Check failure on line 65 in src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs
Azure Pipelines / runtime (Build osx-arm64 Debug AllSubsets_CoreCLR)
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Initialization.cs#L65
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did we consider the alignment of this on 32-bit platforms? As jkotas said in one of the comments, this has 12B on 32 bit platforms, so after adjusting the returned ptr will not be aligned on 8B boundary.
According to the docs, OpenSSL has OPENSSL_aligned_malloc, which it probably uses internally when it matters, but we should still verify that this does not cause any problems.