Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable building with gcc-14 #101623

Merged
merged 5 commits into from May 13, 2024
Merged

Enable building with gcc-14 #101623

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
27bed3d
Enable building with gcc-14
am11 Apr 26, 2024
a826cd1
Delete redundant `PALAPI` attribute
am11 Apr 26, 2024
4455d05
Merge branch 'main' into feature/build/gcc-14
am11 May 13, 2024
28d8d68
Update gcc pipeline to v14
am11 May 13, 2024
0dd385c
Fix -Wcast-user-defined
am11 May 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/nativeSanitizers.targets
View file
Open in desktop
Expand Up @@ -12,7 +12,7 @@
<PropertyGroup Condition="'$(TargetArchitecture)' == 'arm64'">
<LLVMArchitectureSuffix>arm64</LLVMArchitectureSuffix>
</PropertyGroup>
<ItemGroup Condition="'$(TargetOS)' != 'windows'">
<ItemGroup Condition="'$(TargetOS)' != 'windows' and '$(EnableNativeSanitizers)' != ''">
<LinkerArg Include="-fsanitize=$(EnableNativeSanitizers)" />
</ItemGroup>
<ItemGroup Condition="'$(TargetOS)' == 'osx'">
Expand Down
4 changes: 2 additions & 2 deletions src/coreclr/inc/corhlprpriv.h
View file
Open in desktop
Expand Up @@ -474,12 +474,12 @@ template <class T> class CQuickArrayBase : public CQuickBytesBase
template <class T> class CQuickArray : public CQuickArrayBase<T>
{
public:
CQuickArray<T>()
CQuickArray()
{
this->Init();
}

~CQuickArray<T>()
~CQuickArray()
{
this->Destroy();
}
Expand Down
4 changes: 2 additions & 2 deletions src/coreclr/inc/utilcode.h
View file
Open in desktop
Expand Up @@ -843,7 +843,7 @@ template<typename T>
class SimpleListNode
{
public:
SimpleListNode<T>(const T& _t)
SimpleListNode(const T& _t)
{
data = _t;
next = 0;
Expand All @@ -859,7 +859,7 @@ class SimpleList
public:
typedef SimpleListNode<T> NodeType;

SimpleList<T>()
SimpleList()
{
head = NULL;
}
Expand Down
4 changes: 2 additions & 2 deletions src/coreclr/nativeaot/Runtime/unix/UnwindHelpers.cpp
View file
Open in desktop
Expand Up @@ -777,7 +777,7 @@ libunwind::v128 Registers_REGDISPLAY::getVectorRegister(int num) const
{
num -= UNW_ARM64_D8;

if (num < 0 || num >= sizeof(D) / sizeof(uint64_t))
if (num < 0 || (size_t)num >= sizeof(D) / sizeof(uint64_t))
{
PORTABILITY_ASSERT("unsupported arm64 vector register");
}
Expand All @@ -796,7 +796,7 @@ void Registers_REGDISPLAY::setVectorRegister(int num, libunwind::v128 value)
{
num -= UNW_ARM64_D8;

if (num < 0 || num >= sizeof(D) / sizeof(uint64_t))
if (num < 0 || (size_t)num >= sizeof(D) / sizeof(uint64_t))
{
PORTABILITY_ASSERT("unsupported arm64 vector register");
}
Expand Down
5 changes: 3 additions & 2 deletions src/coreclr/pal/inc/pal.h
View file
Open in desktop
Expand Up @@ -3371,8 +3371,9 @@ EXTERN_C PALIMPORT inline RETURN_TYPE PALAPI METHOD_DECL \
/* Function multiversioning will never inline a method that is \
marked such. However, just to make sure that we don't see \
surprises, explicitely mark them as noinline. */ \
__attribute__((target("lse"))) __attribute__((noinline)) \
EXTERN_C PALIMPORT inline RETURN_TYPE PALAPI Lse_##METHOD_DECL \
EXTERN_C PALIMPORT inline RETURN_TYPE PALAPI \
__attribute__((target("+lse"))) __attribute__((noinline)) \
PALAPI Lse_##METHOD_DECL \
{ \
return INTRINSIC_NAME; \
} \
Expand Down
4 changes: 2 additions & 2 deletions src/coreclr/unwinder/arm64/unwinder.cpp
View file
Open in desktop
Expand Up @@ -794,7 +794,7 @@ RtlpExpandCompactToFull (
// or registers to lave left.
//

for (intreg = 0; intreg < ((fnent_pdata->RegI / 2) * 2); intreg += 2) {
for (intreg = 0; intreg < (ULONG)((fnent_pdata->RegI / 2) * 2); intreg += 2) {
if (!sav_predec_done) {
DBG_OP("save_regp_x\t(%s, %s, %i)\n", int_reg_names[intreg], int_reg_names[intreg + 1], -savsz * 8);
emit_save_regp_x(&op_buffer, intreg, -savsz * 8);
Expand Down Expand Up @@ -1484,7 +1484,7 @@ Return Value:
Fpcr = MEMORY_READ_DWORD(UnwindParams, SourceAddress);
SourceAddress = VfpStateAddress + FIELD_OFFSET(KARM64_VFP_STATE, Fpsr);
Fpsr = MEMORY_READ_DWORD(UnwindParams, SourceAddress);
if (Fpcr != -1 && Fpsr != -1) {
if (Fpcr != (ULONG)-1 && Fpsr != (ULONG)-1) {

ContextRecord->Fpcr = Fpcr;
ContextRecord->Fpsr = Fpsr;
Expand Down